Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

score-compose and score-k8s - devcontainer and in CI #73

Merged
merged 13 commits into from
Dec 17, 2024

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Nov 29, 2024

  • make compose-up locally and CI
  • make k8s-up locally and CI
  • .devcontainer

Notes: still issues with make compose-test and make k8s-test, described below. But for now let's merge this first PR as it's already covering the build backstage container in CI now. And let's tackle the 2 remaining issues in future PRs.

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner November 29, 2024 21:17
@mathieu-benoit mathieu-benoit marked this pull request as draft November 29, 2024 21:17
@astromechza
Copy link

The first issue is because score-compose's default environment provisioner tries to use the shell environment variables at deploy time. However we can't template those into the mounted file at deploy time. The solution here is generally to set a custom environment provisioner from your makefile and import it at score-compose init time.

The second issue I've cut score-spec/score-compose#219 for.

@mathieu-benoit mathieu-benoit self-assigned this Dec 6, 2024
@mathieu-benoit
Copy link
Contributor Author

Ready for your review to be merged, thanks!

@mathieu-benoit mathieu-benoit merged commit d55834c into main Dec 17, 2024
2 checks passed
@mathieu-benoit mathieu-benoit deleted the score-local branch December 17, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants