Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to open output of pep next in browser #50

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Oct 12, 2023

For some reason, this never happened to me on macOS even though I was initially expecting it.

But it does occur on Linux:

pep next opens file:///home/username/python/main/Next%20available%20PEP:%20731 URL in a browser. This URL doesn't exist.

Don't attempt to open such output.

@hugovk hugovk added the changelog: Fixed For any bug fixes label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #50 (589bda3) into main (eb1cf0f) will decrease coverage by 0.86%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main      #50      +/-   ##
===========================================
- Coverage   100.00%   99.14%   -0.86%     
===========================================
  Files            4        4              
  Lines          230      233       +3     
===========================================
+ Hits           230      231       +1     
- Misses           0        2       +2     
Flag Coverage Δ
macos-latest 99.14% <100.00%> (-0.86%) ⬇️
ubuntu-latest 99.14% <100.00%> (-0.86%) ⬇️
windows-latest 99.14% <100.00%> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pepotron/__init__.py 98.07% <100.00%> (-1.93%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hugovk hugovk merged commit c6cc760 into main Oct 12, 2023
46 of 48 checks passed
@hugovk hugovk deleted the fix-pep-next branch October 12, 2023 22:52
@hugovk hugovk changed the title Don't attempt to open output of 'pep next' in browser Don't attempt to open output of pep next in browser Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant