Resolved network issue

We used to store a temporary part of network result of every ApiQuery
in a string and on every ReadData event we converted that QByteArray
into a string and appended it to this temporary string.

This was wrong as the QByteArray didn't contain whole Unicode text but
only a part of it that might be just a half of a symbol or just something
invalid that couldn't be parsed by QString.

That resulted in randomly corrupt symbols in some pages, that in case of
software rollback were written back to wikipedia.

Now we store the parts of QByteArray to a temporary QByteArray which
converted to QString in one shot later. It uses a bit more operating
memory and less CPU, but it works.

huggle/apiquery.cpp

@@ -198,7 +198,10 @@ void ApiQuery::Finished()
     if (this->reply == nullptr)
         throw new Huggle::NullPointerException("loc ApiQuery::reply", BOOST_CURRENT_FUNCTION);
     ApiQueryResult *result = (ApiQueryResult*)this->Result;
-    result->Data += QString(this->reply->readAll());
+    this->temp += this->reply->readAll();
+    result->Data = QString(this->temp);
+    // remove the temporary data so that we save the ram
+    this->temp.clear();
     // now we need to check if request was successful or not
     if (this->reply->error())
     {
@@ -242,6 +245,7 @@ void ApiQuery::Process()
     }
     this->StartTime = QDateTime::currentDateTime();
     this->ThrowOnValidResult();
+    this->temp.clear();
     if (!this->URL.size())
         this->ConstructUrl();
     this->Status = StatusProcessing;
@@ -305,11 +309,9 @@ void ApiQuery::ReadData()
     // don't even try to do anything if query was killed
     if (this->Status == StatusKilled)
         return;
-    if (this->Result == nullptr)
-        throw new Huggle::NullPointerException("loc ApiQuery::Result", BOOST_CURRENT_FUNCTION);
     if (this->reply == nullptr)
         throw new Huggle::NullPointerException("loc ApiQuery::reply", BOOST_CURRENT_FUNCTION);
-    this->Result->Data += QString(this->reply->readAll());
+    this->temp += this->reply->readAll();
 }
 
 void ApiQuery::SetAction(const Action action)

huggle/apiquery.hpp

@@ -114,6 +114,7 @@ namespace Huggle
             //! This is only needed when you are using rollback
             void FinishRollback();
             QString ActionPart;
+            QByteArray temp;
             //! Reply from qnet
             QNetworkReply *reply = nullptr;
     };

huggle/webserverquery.cpp

@@ -82,11 +82,9 @@ void WebserverQuery::ReadData()
 {    // don't even try to do anything if query was killed
     if (this->Status == StatusKilled)
         return;
-    if (this->Result == nullptr)
-        throw new Huggle::NullPointerException("loc WebserverQuery::Result", BOOST_CURRENT_FUNCTION);
     if (this->reply == nullptr)
         throw new Huggle::NullPointerException("loc WebserverQuery::reply", BOOST_CURRENT_FUNCTION);
-    this->Result->Data += QString(this->reply->readAll());
+    this->temp += this->reply->readAll();
 }
 
 void WebserverQuery::Finished()
@@ -98,7 +96,9 @@ void WebserverQuery::Finished()
         throw new Huggle::NullPointerException("loc WebserverQuery::Result", BOOST_CURRENT_FUNCTION);
     if (this->reply == nullptr)
         throw new Huggle::NullPointerException("loc WebserverQuery::reply", BOOST_CURRENT_FUNCTION);
-    this->Result->Data += QString(this->reply->readAll());
+    this->temp += this->reply->readAll();
+    this->Result->Data = QString(this->temp);
+    this->temp.clear();
     // now we need to check if request was successful or not
     if (this->reply->error())
     {

huggle/webserverquery.hpp

@@ -42,6 +42,7 @@ namespace Huggle
             void Kill();
         private:
             QNetworkReply *reply = nullptr;
+            QByteArray temp;
         private slots:
             void ReadData();
             void Finished();