Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pypi release #81

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Pypi release #81

merged 4 commits into from
Aug 8, 2024

Conversation

tengomucho
Copy link
Collaborator

What does this PR do?

A pypi release workflow was added previously to this repository, but it is not working, so I am trying to make this work:

  • I set the Dev status to pre-alpha.
  • I update the workflow to only push on pypi when the release is published, instead of matching a tag pattern. My idea is that I will tag a version, test it on pypi-test and then I can release it once it's tested.

@tengomucho tengomucho requested a review from regisss August 8, 2024 10:47
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

regisss
regisss approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tengomucho tengomucho merged commit a2a015b into main Aug 8, 2024
4 checks passed
@tengomucho tengomucho deleted the pypi-release branch August 8, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengomucho @HuggingFaceDocBuilderDev @regisss