👷 Add integration test to the CI #140
Conversation
baptistecolle
force-pushed
the
fix-integration-test-tgi-with-ci
branch
from
66ebdb7 to
a7af4f1
Compare
baptistecolle
force-pushed
the
fix-integration-test-tgi-with-ci
branch
from
a7af4f1 to
5187173
Compare
| HF_HUB_CACHE: /mnt/hf_cache/cache_huggingface | ||
| HF_TOKEN: ${{ secrets.HF_TOKEN_OPTIMUM_TPU_CI }} | ||
| V5_LITEPOD_8_ENV: ${{ vars.V5_LITEPOD_8_ENV}} | ||
|
|
There was a problem hiding this comment.
this does not have container section, does it means it runs on the VM directly?
There was a problem hiding this comment.
Yes, indeed, if you run in the container directly, you have networking issues. So we use the VM directly that spawn the container
| PJRT_DEVICE: TPU | ||
| HF_HUB_CACHE: /mnt/hf_cache/cache_huggingface | ||
| HF_TOKEN: ${{ secrets.HF_TOKEN_OPTIMUM_TPU_CI }} | ||
| V5_LITEPOD_8_ENV: ${{ vars.V5_LITEPOD_8_ENV}} |
There was a problem hiding this comment.
I wonder if it might be better to rename this into something mode generic, e.g.: TPU_ENV, the reason being that we will soon need to support v6e too.
| tpu-tgi: | ||
| docker build --rm -f text-generation-inference/docker/Dockerfile \ | ||
| --build-arg VERSION=$(VERSION) \ | ||
| --build-arg TGI_VERSION=$(TGI_VERSION) \ | ||
| --ulimit nofile=100000:100000 \ | ||
| $(if $(NETWORK),--network $(NETWORK),) \ |
There was a problem hiding this comment.
why do we need the network hot at this step?
There was a problem hiding this comment.
This is needed for the CI. If you build with the default network, some requests during the build process are blocked. For example, the protobuf installation fails.
What does this PR do?
This PR adds the TGI docker integration test to the CI.
This is related to issue #124 about the new integration test for TGI.
Link to the new action execution: https://github.com/huggingface/optimum-tpu/actions/runs/12667037809/job/35299701615
Special thanks to @paulinebm for all the help debugging the CI 🙌