Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: graceful shutdown was not working with entrypoint, exec launcher #112

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: graceful shutdown was not working with entrypoint, exec launcher #112

merged 1 commit into from
Nov 5, 2024

Conversation

co42
Copy link
Collaborator

@co42 co42 commented Nov 5, 2024

No description provided.

@co42 co42 requested a review from alvarobartt November 5, 2024 10:17
tengomucho
tengomucho approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@tengomucho tengomucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To leave a trace that explains why we do this: we need it to have the launcher receiving the signal and gracefully shutdown. This is aligned with TGI >= 2.4.0 entrypoint.

@tengomucho tengomucho merged commit 76b28e7 into main Nov 5, 2024
3 checks passed
@tengomucho tengomucho deleted the fix/shutdown-with-exec branch November 5, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengomucho tengomucho tengomucho approved these changes

@alvarobartt alvarobartt Awaiting requested review from alvarobartt

@baptistecolle baptistecolle Awaiting requested review from baptistecolle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@co42 @tengomucho