Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing barriers #273

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Removing barriers #273

merged 7 commits into from
Sep 23, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil commented Sep 23, 2024

seems that newer versions of PyTorch have better torch.distributed implementation and calling barriers is no longer necessary in our case.

@IlyasMoutawwakil IlyasMoutawwakil changed the title Test removing barriers Removing barriers Sep 23, 2024
@IlyasMoutawwakil IlyasMoutawwakil merged commit 1c43fa2 into main Sep 23, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant