-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev(narugo): add resume for ranged headers of http_get function #2823
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @narugo1992, thanks a lot for your contribution!
I left some comments and I took the initiative to push to your branch an improvement of the http get tests to use pytest instead of unittest. It's a bit out of scope of this PR, but it consolidates the tests you added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @narugo1992 for your contribution 🤗
I pushed a simplification of the _adjust_range_header
, everything looks good now! Let's wait for a final review from @Wauplin and then we should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping. Maybe I'm wrong but I feel we should be more conservative on the use cases we want to support
i.e., better to raise explicit errors for now on corner cases and add them later if we think they are useful
for issue #2761