Default to base_url
if provided
#2805
Merged
+21
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2804.
base_url
was first introduced to match OpenAI chat completion API. It has the exact same behavior asself.model
when usingclient.chat_completion
. However, since it's a public parameter also for other tasks, I do think it makes sense to use it if provided. The problem in #2804 was that user provided a URL asbase_url
and expected it to be used intext_generation
(which seems fair) but wasn't. Therefore it defaults to Inference API with default model which in not intended. This small PR should prevent this.Not related at all but I took the opportunity to rephrase a bit the error raised in case of a 422 unprocessable entity. Usually the response body provides information about what's missing/not valid. Let's add it to the error message as a string.