Updating HfApi objects to use dataclass #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Thanks @Ahmedniz1!
Left 3 small comments to update but that's all. Then we should be able to merge 🎉
src/huggingface_hub/hf_api.py
Outdated
| oid: str | ||
| title: str | ||
| date: datetime | ||
|
|
||
| def __post_init__(self): # hack to make BlobLfsInfo backward compatible |
There was a problem hiding this comment.
Suggested change
| def __post_init__(self): # hack to make BlobLfsInfo backward compatible | |
| def __post_init__(self): # hack to make LastCommitInfo backward compatible |
src/huggingface_hub/hf_api.py
Outdated
| safe: bool | ||
| av_scan: Optional[Dict] | ||
| pickle_import_scan: Optional[Dict] | ||
|
|
||
| def __post_init__(self): # hack to make BlobLfsInfo backward compatible |
There was a problem hiding this comment.
Suggested change
| def __post_init__(self): # hack to make BlobLfsInfo backward compatible | |
| def __post_init__(self): # hack to make BlobSecurityInfo backward compatible |
src/huggingface_hub/hf_api.py
Outdated
| parameters: List[Dict[str, int]] | ||
| total: int | ||
|
|
||
| def __post_init__(self): # hack to make BlobLfsInfo backward compatible |
There was a problem hiding this comment.
Suggested change
| def __post_init__(self): # hack to make BlobLfsInfo backward compatible | |
| def __post_init__(self): # hack to make SafeTensorsInfo backward compatible |
|
@Wauplin I've updated the comments. |
|
Thanks for the update @Ahmedniz1! Failing tests are unrelated so we're good to merge 🎉 Thanks again for the contribution! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1911
I've updated all classes to use dataclass except (transformerinfo class).