❇️ FEAT(local-apps): add ComfyUI LocalApp #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tildebyte
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
|
Sorry for the churn. Opening a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #855
RE: the discussion in ⬆️ - to the best of of my knowledge there's no way to ask vanilla Comfy[1] to d/l a model for you; it's completely manual
Related to above:
deeplinkis almost certainly incorrect, but 1) the local type checker was very pissed about it not being present 2) I don't know the HF API well enough to know what to put there.Apologies for no local verification/testing; I'm not a TS person, and it would take me longer to figure out/set up than it took me to write the code 😁
[1] There are probably 3rd-party nodes to do so, but it's more likely that such a thing would build a list of its own in some way