Update tasks (important ones) #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merveenoyan
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
Vaibhavs10
approved these changes
Feb 3, 2025
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
|
@Vaibhavs10 thanks for swift review, I addressed your comments |
Vaibhavs10
approved these changes
Feb 3, 2025
|
we need a review from codeowners I think (but also nearly none of the tests pass so idk) |
pcuenca
approved these changes
Feb 3, 2025
|
(checking the linter) |
|
|
Co-authored-by: Pedro Cuenca <[email protected]>
Merged
Wauplin
added a commit
that referenced
this pull request
Feb 5, 2025
should fix lint issue introduced in #1163 will merge if lint CI gets green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to open a follow-up PR to this with more explanatory content on text generation because I see community is quite confused with DeepSeek being out and people don't know difference between model types etc. Also we need to update docs with new inference providers etc.
For now this PR updates VLM widget to Qwen2VL because Llama Vision isn't open to everyone + updates some text generation and VLMs on tasks (I find these changes to be a bit more prio hence don't want to open a big PR that will take long to get merged)