Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more fal.ai models #1139

Merged
merged 4 commits into from
Jan 28, 2025
Merged

add more fal.ai models #1139

merged 4 commits into from
Jan 28, 2025

Conversation

gokayfem
Copy link
Contributor

adds more fal.ai models

@@ -23,5 +25,7 @@ export const FAL_AI_SUPPORTED_MODEL_IDS: ProviderMapping<FalAiId> = {
"text-to-video": {
"genmo/mochi-1-preview": "fal-ai/mochi-v1",
"tencent/HunyuanVideo": "fal-ai/hunyuan-video",
"THUDM/CogVideoX-5b": "fal-ai/cogvideox-5b",
"Lightricks/LTX-Video": "fal-ai/ltx-video",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is nice bc it's super fast IIRC cc @SBrandeis ^

@SBrandeis
Copy link
Contributor

SBrandeis commented Jan 27, 2025

Nice!
Do you mind adding some tests to make sure the APIs are compatible @gokayfem ?

You can take inspiration from the other text-to-video tests here:

it("textToVideo - genmo/mochi-1-preview", async () => {
const res = await textToVideo({
model: "genmo/mochi-1-preview",
inputs: "A running dog",
parameters: {
seed: 176,
},
provider: "fal-ai",
accessToken: env.HF_FAL_KEY,
});
expect(res).toBeInstanceOf(Blob);
});
it("textToVideo - HunyuanVideo", async () => {
const res = await textToVideo({
model: "genmo/mochi-1-preview",
inputs: "A running dog",
parameters: {
seed: 176,
num_inference_steps: 2,
num_frames: 85,
resolution: "480p",
},
provider: "fal-ai",
accessToken: env.HF_FAL_KEY,
});
expect(res).toBeInstanceOf(Blob);
});

@aykutkardas
Copy link
Contributor

Nice! Do you mind adding some tests to make sure the APIs are compatible @gokayfem ?

You can take inspiration from the other text-to-video tests here:

I added the tests. ✅

@@ -816,7 +816,7 @@ describe.concurrent("HfInference", () => {

it("textToVideo - HunyuanVideo", async () => {
const res = await textToVideo({
model: "genmo/mochi-1-preview",
model: "tencent/HunyuanVideo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gokayfem and @aykutkardas !

@SBrandeis SBrandeis merged commit df42566 into huggingface:main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants