-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️ Use tshy
instead of tsup
for releasing tasks
#1029
Conversation
"watch:cjs": "tsc --declaration --outdir dist/commonjs --module commonjs --watch", | ||
"watch:esm": "tsc --declaration --outdir dist/esm --watch", | ||
"watch": "npm-run-all --parallel watch:esm watch:cjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @krampstudio , hopefully it still works
const rootDir = rootDirFinder(); | ||
const rootDir = path.join(rootDirFinder(), "..", "tasks"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just do const rootDir = "../tasks"
since the script is always executed in the /packages/tasks-gen
context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't try it (obviously), but lgtm 😄
interesting CI errors haha ^^' |
well yea, going bakc to adding main/module/types fields |
but yeah for now probably simpler :) |
I could remove the fields, but then we have to update the moon codebase ASAP :) |
Follow up to #1026
Benefit is that exports are better defined, and source-mapping works.
Also, move the generation scripts from
@huggingace/tasks
to@huggingface/tasks-gen
cc @Wauplin @SBrandeisSo that the dev dependencies are not tacked on
@huggingface/tasks
. Some package managers, cough yarn cough like to download them when importing a package, even if they're irrelevant.