💥 Switch gguf & tasks interdependency #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
requested review from
mishig25,
julien-c,
SBrandeis,
gary149,
Wauplin and
pcuenca
as code owners
julien-c
approved these changes
Nov 1, 2024
ngxson
approved these changes
Nov 1, 2024
coyotte508
deleted the
1000-remove-huggingfacetasks-dependency-on-huggingfacegguf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ngxson too (you can add yourself to CODEOWNERS for gguf maybe :) )
Move the functions needed by
@huggingface/tasksdirectly into@huggingface/tasks.Now
@hugginface/ggufdepends on@huggingface/tasksand not the other way around.The move is minimal, more could be moved. (Or a fancy solution with shared folders, but fancy solutions can become complicated esp with publishing source code along with dist. Or we could just duplicate the code, and maybe add CI check to ensure consistency)