Update sagemaker docs structure #1645
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
this file is not showing up as a page anymore--I can include it as a section called "Examples" if helpful
There was a problem hiding this comment.
Yes I think we should keep this page for now. There's not only a list of notebook examples but also a useful doc on the inference toolkit.
There was a problem hiding this comment.
Not sure what makes sense for the title of the page. There are not only examples but also API specs, so I wouldn't call it "Examples". maybe the best is to keep "Reference" for now?
|
Hello Arjuna, thanks for the PR! |
|
|
||
| ### SM Example | ||
| ``` | ||
| # create Hugging Face Model Class |
There was a problem hiding this comment.
We should add the import in the code snippet
| ``` | ||
| # create Hugging Face Model Class | ||
| huggingface_model = HuggingFaceModel( | ||
| image_uri=get_huggingface_llm_image_uri("huggingface",version="2.3"), |
There was a problem hiding this comment.
The util doesn't work for Pytorch training DLC, no?
Sounds reasonable. We can keep it in one file for now and then restructure later. That being said, if the headings in the same file are still "TGI", "Transformers", etc, customers will still need to know the library names to know what to use, similarly to if these are the titles of subheadings. Is there a better way to denote the differences that might be more intuitive? |
Yes I think the list of containers deserve a short intro / how to section where you explain the rational on how to pick the right container for your usecase. For a basic intro, I'd say there are two main things to explain:
We could have a more complex version of the decision tree in an "advanced section". It could take into account more factors like quantization, target hardware etc.. This doc doesn't exist but becomes more necessary now TGI is multibackend. |
|
Btw, I think the name we use are Pytorch Inference DLC and Pytorch Training DLC over Transformers DLC. I don't know if it's a good name and we can change it, as long as we stay consistent. |
Update sagemaker docs structure to remove references to old images, as well as structure in a way where automated PRs will update tables