Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add size to Siblings #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kczimm
Copy link

@kczimm kczimm commented Dec 20, 2023

Add the file size to the Siblings struct.

Copy link
Member

@McPatate McPatate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @Narsil ?

@Narsil
Copy link
Collaborator

Narsil commented Jan 31, 2024

This would need to be done to both sync/async parts.

I'd rather make it easer for everyone to get exactly what they want. This is what info_request() should get you.
With info_request users can get exactly what they want (including the size or not, or any other information).

I think maybe expanding/showcasing this might be more useful than modifying this for everyone.
We should probably add a link within info too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants