Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy from env. #34

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add proxy from env. #34

merged 1 commit into from
Oct 30, 2023

Conversation

wh7f
Copy link
Contributor

@wh7f wh7f commented Oct 17, 2023

In mainland China, people usually need to access the international internet through a proxy.
Otherwise, they may encounter connection errors.
For example: error trying to connect: tcp connect error: Connection timed out (os error 110)

So it's necessary to support obtaining proxy configurations from environment variables to facilitate the use by users in mainland China.

@jtsai-quid
Copy link

hi @Narsil ,
In our cluster, a proxy is essential for accessing the public network.
We came across this issue while upgrading TGI to 1.1.0, which resulted in the tokenizer being unable to load through the proxy.(see here and here)
Would you please have a look at this PR?
Many thanks

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Narsil Narsil merged commit 5bc4b45 into huggingface:main Oct 30, 2023
3 checks passed
@jtsai-quid
Copy link

hi @Narsil,
When is the expected release date for the next version to come with this patch?
Many thanks

@dimakuv
Copy link

dimakuv commented Jul 10, 2024

When is the expected release date for the next version to come with this patch?

I also encountered this issue. Would like to bump the priority of releasing a new version with this patch.

@kerthcet
Copy link

Kindly ping @Narsil have no idea about hf release schedule, but seems we haven't cut a new one for a long time, maybe worths a new release? We also meet this problem and solved it by enable the proxy-from-env feature of ureq, which will enable the proxy underground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants