Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add minimal testing for legacy Torch versions #10479

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Jan 7, 2025

What does this PR do?

Imports in the TorchAO PR: #10009 broke Diffusers imports for torch<2.3. Adding minimal testing to the nightly and release tests with a torch 2.1 image to catch issues such as this.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 changed the title Add minimal testing for legacy Torch versions [CI] Add minimal testing for legacy Torch versions Jan 7, 2025
@DN6 DN6 requested a review from sayakpaul January 7, 2025 05:57
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we want to do something similar for torch < 2.0?

@DN6 DN6 merged commit 854a046 into main Jan 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants