flux: make scheduler config params optional #10384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hlky
reviewed
Dec 25, 2024
Comment on lines
+77
to
+94
| base_seq_len: Optional[int] = 256, | ||
| max_seq_len: Optional[int] = 4096, | ||
| base_shift: Optional[float] = 0.5, | ||
| max_shift: Optional[float] = 1.16, | ||
| scheduler: Optional[FlowMatchEulerDiscreteScheduler] = None, | ||
| ): | ||
| if base_seq_len or max_seq_len or base_shift or max_shift or scheduler is None: | ||
| deprecation_message = "Pass `scheduler` to `calculate_shift`." | ||
| deprecate( | ||
| "calculate_shift scheduler", | ||
| "1.0.0", | ||
| deprecation_message, | ||
| standard_warn=False, | ||
| ) | ||
| base_seq_len = base_seq_len or scheduler.config.get("base_image_seq_len", 256) | ||
| max_seq_len = max_seq_len or scheduler.config.get("max_image_seq_len", 4096) | ||
| base_shift = base_shift or scheduler.config.get("base_shift", 0.5) | ||
| max_shift = max_shift or scheduler.config.get("max_shift", 1.16) |
There was a problem hiding this comment.
Thanks for the contribution @vladmandic, it will be fun to try to those scheduler changes with Flux.
As you mentioned CI, I've ran make fix-copies to demonstrate. Every occurrence of # Copied from diffusers.pipelines.flux.pipeline_flux.calculate_shift is updated, this highlights the effects in our own codebase, we'll need to update the call of calculate_shift in every pipeline and there can be effects downstream, so I've pushed this version which adds a deprecation message. We'll run make fix-copies again when the changes here are finalised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that we have flow support for most of the schedulers, we really should not rely on hardcoded optional scheduler config values inside the pipeline - they should be optional.
without this change, flux pipeline will fail for most non-default schedulers (with flow mode enabled) due to missing config value.
note that this change needs to be mirrored for all flux pipelines, but due to how diffusers ci works, i'm really not sure what needs to be manually updated vs not.
@hlky @yiyixuxu