Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a dtype issue when evaluating the sana transformer with a float16 autocast context #10362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nerogar
Copy link

@Nerogar Nerogar commented Dec 23, 2024

What does this PR do?

the query, key and value tensors of the attention calculations are already converted to float32 format. But if an autocast context is active, intermediate values are still converted back to float16 precision. Disabling autocast in this region prevents this unwanted conversion. The result is then converted back to the original dtype afterwards.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@lawrence-cj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant