Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of Attention.head_to_batch_dim issue #10303 #10312

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dawn-LX
Copy link

@Dawn-LX Dawn-LX commented Dec 20, 2024

What does this PR do?

Fixes issue #10303

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@hlky
Copy link
Collaborator

hlky commented Dec 20, 2024

@hlky
Copy link
Collaborator

hlky commented Dec 20, 2024

@Dawn-LX Can you confirm there is some case where the output shape as it was is incorrect? From the failing tests it looks like the comment is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants