-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sharded models when TorchAO quantization is enabled #10256
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
997e56c
add sharded + device_map check
a-r-r-o-w c129428
fix
a-r-r-o-w 739601c
add test for sharded model
a-r-r-o-w d6b6aea
Merge branch 'main' into torchao-error-on-sharded-device-map
a-r-r-o-w 9ec70f0
Update tests/quantization/torchao/test_torchao.py
a-r-r-o-w fe447ba
address review comments
a-r-r-o-w e3ff590
Merge branch 'main' into torchao-error-on-sharded-device-map
a-r-r-o-w 05276c4
revert changes to pipeline utils
a-r-r-o-w 4a8c0ed
Merge branch 'main' into torchao-error-on-sharded-device-map
a-r-r-o-w 3822ead
remove unused file
a-r-r-o-w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -45,6 +45,7 @@ | |||||
from ..models.attention_processor import FusedAttnProcessor2_0 | ||||||
from ..models.modeling_utils import _LOW_CPU_MEM_USAGE_DEFAULT, ModelMixin | ||||||
from ..quantizers.bitsandbytes.utils import _check_bnb_status | ||||||
from ..quantizers.torchao.utils import _check_torchao_status | ||||||
from ..schedulers.scheduling_utils import SCHEDULER_CONFIG_NAME | ||||||
from ..utils import ( | ||||||
CONFIG_NAME, | ||||||
|
@@ -388,6 +389,7 @@ def to(self, *args, **kwargs): | |||||
|
||||||
device = device or device_arg | ||||||
pipeline_has_bnb = any(any((_check_bnb_status(module))) for _, module in self.components.items()) | ||||||
pipeline_has_torchao = any(_check_torchao_status(module) for _, module in self.components.items()) | ||||||
|
||||||
# throw warning if pipeline is in "offloaded"-mode but user tries to manually set to GPU. | ||||||
def module_is_sequentially_offloaded(module): | ||||||
|
@@ -411,7 +413,7 @@ def module_is_offloaded(module): | |||||
module_is_sequentially_offloaded(module) for _, module in self.components.items() | ||||||
) | ||||||
if device and torch.device(device).type == "cuda": | ||||||
if pipeline_is_sequentially_offloaded and not pipeline_has_bnb: | ||||||
if pipeline_is_sequentially_offloaded and not (pipeline_has_bnb or pipeline_has_torchao): | ||||||
raise ValueError( | ||||||
"It seems like you have activated sequential model offloading by calling `enable_sequential_cpu_offload`, but are now attempting to move the pipeline to GPU. This is not compatible with offloading. Please, move your pipeline `.to('cpu')` or consider removing the move altogether if you use sequential offloading." | ||||||
) | ||||||
|
@@ -420,6 +422,12 @@ def module_is_offloaded(module): | |||||
raise ValueError( | ||||||
"You are trying to call `.to('cuda')` on a pipeline that has models quantized with `bitsandbytes`. Your current `accelerate` installation does not support it. Please upgrade the installation." | ||||||
) | ||||||
elif pipeline_has_torchao: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
raise ValueError( | ||||||
"You are trying to call `.to('cuda')` on a pipeline that has models quantized with `torchao`. This is not supported. There are two options on what could be done to fix this error:\n" | ||||||
"1. Move the individual components of the model to the desired device directly using `.to()` on each.\n" | ||||||
'2. Pass `device_map="balanced"` when initializing the pipeline to let `accelerate` handle the device placement.' | ||||||
) | ||||||
|
||||||
is_pipeline_device_mapped = self.hf_device_map is not None and len(self.hf_device_map) > 1 | ||||||
if is_pipeline_device_mapped: | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Copyright 2024 The HuggingFace Inc. team. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from ..quantization_config import QuantizationMethod | ||
|
||
|
||
def _check_torchao_status(module) -> bool: | ||
a-r-r-o-w marked this conversation as resolved.
Show resolved
Hide resolved
|
||
is_loaded_in_torchao = getattr(module, "quantization_method", None) == QuantizationMethod.TORCHAO | ||
return is_loaded_in_torchao |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to skip the error message for now?
the issue of not being able use
pipe.to("cuda")
when the pipe has a device mapped module, has nothing to do with torchAO, if we do not throw an error here and then we make sure not to move the module with device_map later here, it would workdiffusers/src/diffusers/pipelines/pipeline_utils.py
Line 457 in 4450d26
some refactor is needed, though, and I don't think needs to be done in this PR