Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uppercase typo in code_agents.ipynb in party theme selection #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix uppercase typo in code_agents.ipynb in party theme selection #255

wants to merge 1 commit into from

Conversation

francisco-perez-sorrosal
Copy link

As the category parameter is converted to lowercase the original key fot theme "futuristic Gotham" was never gonna be selected.

@francisco-perez-sorrosal
Fix uppercase typo in code_agents.ipynb in party theme selection
617e991 
As the category parameter is converted to lowercase the original key fot theme "futuristic Gotham" was never gonna be selected.
@francisco-perez-sorrosal
Copy link
Author

BTW this is repeated in subsequent notebooks as the unit 2 progresses

sergiopaniego
sergiopaniego approved these changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiopaniego sergiopaniego sergiopaniego approved these changes

@rahmani3101 rahmani3101 rahmani3101 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francisco-perez-sorrosal @sergiopaniego @rahmani3101