feat(config): support starting pd nodes & store nodes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbajin
reviewed
Sep 19, 2024
src/common/deploy_graph.py
Outdated
There was a problem hiding this comment.
could use 100 or 120 as the line wrapping standard, no need wrap too early
40 tasks
imbajin
reviewed
Sep 23, 2024
| @@ -23,7 +23,12 @@ Note: modify the configs in basic_config.py before run the test script | |||
| 2. modify server/toolchain_git_branch_commit | |||
| 3. modify auth/https/serice ports if need.. | |||
| ''' | |||
| python deploy_start.py all # or 'server' or 'toolchain' | |||
| python deploy_start.py all # or 'server' or 'toolchain' or 'hugegraph' | |||
There was a problem hiding this comment.
hugegraph represents "server + pd + store"?
There was a problem hiding this comment.
yes, use hugegraph to start a cluster including 1 pd, 1 store and 1 server
imbajin
reviewed
Sep 23, 2024
src/deploy_start.py
Outdated
| graph_deploy(sys.argv[1], basic_config) | ||
| else: | ||
| print('failed: 执行脚本参数为[all,server,toolchain]') | ||
| print('failed: 执行脚本参数为[all,server,toolchain, pd, store, hugegraph]') |
There was a problem hiding this comment.
sort the order from big -> small (scope)
imbajin
reviewed
Sep 24, 2024
imbajin
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of apache/incubator-hugegraph#2575