Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclusive prank/broadcast #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paco0x
Copy link

@paco0x paco0x commented Dec 3, 2023

Currently, running HuffDeployer.broadcast("T"); would fail:

   │   ├─ [0] VM::prank(HuffConfig: [0xC7f2Cf4845C6db0e1a1e91ED41Bcd0FcC1b0E141])
    │   │   └─ ← ()
    │   ├─ [0] VM::ffi(["rm", "src/__TEMP__abfzyqnaxzhwmracwudpzrzbuoyhhizhT.huff"])
    │   │   └─ ← 0x
    │   ├─ [0] VM::broadcast()
    │   │   └─ ← you have an active prank; broadcasting and pranks are not compatible
    │   └─ ← you have an active prank; broadcasting and pranks are not compatible
    └─ ← you have an active prank; broadcasting and pranks are not compatible


Error:
script failed: you have an active prank; broadcasting and pranks are not compatible

vm.prank() is not needed when should_broadcast is true.

Copy link

@0xClandestine 0xClandestine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants