Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMKC] Email Audits for Review #1721

Closed
wants to merge 3 commits into from
Closed

[CMKC] Email Audits for Review #1721

wants to merge 3 commits into from

Conversation

jessewoo
Copy link
Contributor

@jessewoo jessewoo commented Jun 10, 2024

Source JIRA card(s) and hubzero ticket(s)

https://sdx-sdsc.atlassian.net/browse/USP-193

Brief summary of the issue

PART 2: Audits the different email setTo() of other files
PART 1: #1723

Brief summary of the fix

Did a grep on other files on core changes, in the email object for those files, updated to be sent Bcc (blind carbon copy) instead of To or Cc.

Brief summary of your testing

Have not tried testing on woo.aws.hubzero.org

Do the change needs to be hotfixed to any production hubs before a normal core rollout

Not at the moment, we can do this when there is more time.

Double check someone is assigned to review the ticket

Yes - Nick and David

@jessewoo jessewoo self-assigned this Jun 10, 2024
@jessewoo
Copy link
Contributor Author

Hi @nkissebe - tried removing and adding back setTo, but when I removed the setTo(), without it, I don't receive an email at all. But putting the setTo() back in, I do receive the email.

@jessewoo
Copy link
Contributor Author

jessewoo commented Jun 14, 2024

able to update the files from grep:

image

@jessewoo
Copy link
Contributor Author

image

@jessewoo jessewoo changed the title [CMKC] Group Invite Bcc Emails [CMKC] Email Audits Jun 15, 2024
@jessewoo jessewoo changed the title [CMKC] Email Audits [CMKC] Email Audits for Review Jun 15, 2024
@jessewoo jessewoo closed this Jun 15, 2024
@jessewoo jessewoo deleted the bccGroupInvites branch June 15, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant