Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to auto-generate diffs #90

Closed
wants to merge 1 commit into from
Closed

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Jul 23, 2024

This workflow will run whenever one of use (the repo owners) adds the /diff comment in a pull request. It will generate a highlighted diff of the schema as a GitHub comment.

This uses two external actions

@zkamvar zkamvar added the CI label Jul 23, 2024
@annakrystalli
Copy link
Member

annakrystalli commented Jul 23, 2024

This is super useful!

I've actually added documentation to the README in PR #88 which will be obsolete by this PR. It would also be nice to document this new feature in the README instead.

Would you mind:

  1. Redirecting the PR to Add output_type_id_datatype property to v3.0.1. Resolves #87 #88
  2. Removing any obsolete documentation in the README and adding a note about the new feature?

@zkamvar
Copy link
Member Author

zkamvar commented Jul 23, 2024

closing in favour of suggestions made in #90 (comment)

@zkamvar zkamvar closed this Jul 23, 2024
@zkamvar zkamvar deleted the add-diff-commenter branch July 23, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants