Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iotda): refactor amqp resource code style #6251

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Jan 23, 2025

What this PR does / why we need it:

commit1: refactor amqp resource code style
commit2: amqp resource support new attribute fields

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


refactor `amqp` resource code style

PR Checklist

  • Tests added/passed.
$ export HW_IOTDA_ACCESS_ADDRESS=xxxxxxxxxxxx

$ make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccAmqp_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccAmqp_basic -timeout 360m -parallel 4
=== RUN   TestAccAmqp_basic
=== PAUSE TestAccAmqp_basic
=== CONT  TestAccAmqp_basic
--- PASS: TestAccAmqp_basic (12.05s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda     12.112s

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@jinyangyang222 jinyangyang222 force-pushed the refactor-iotda/refactor-amqp-codeStyle branch from 13278ae to 81ca3e5 Compare January 24, 2025 01:25
@jinyangyang222
Copy link
Contributor Author

make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccAmqp_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccAmqp_basic -timeout 360m -parallel 4
=== RUN TestAccAmqp_basic
=== PAUSE TestAccAmqp_basic
=== CONT TestAccAmqp_basic
--- PASS: TestAccAmqp_basic (14.79s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda 14.839s

@github-actions github-actions bot removed the feature label Jan 24, 2025
@jinyangyang222 jinyangyang222 force-pushed the refactor-iotda/refactor-amqp-codeStyle branch from 81ca3e5 to 472df82 Compare January 24, 2025 01:41
@jinyangyang222 jinyangyang222 force-pushed the refactor-iotda/refactor-amqp-codeStyle branch from 472df82 to faddccb Compare January 24, 2025 01:52
@jinyangyang222
Copy link
Contributor Author

make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccAmqp_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccAmqp_basic -timeout 360m -parallel 4
=== RUN TestAccAmqp_basic
=== PAUSE TestAccAmqp_basic
=== CONT TestAccAmqp_basic
--- PASS: TestAccAmqp_basic (13.34s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda 13.421s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 5877401 into huaweicloud:master Jan 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants