-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iotda): refactor amqp resource code style #6251
refactor(iotda): refactor amqp resource code style #6251
Conversation
huaweicloud/services/acceptance/iotda/resource_huaweicloud_iotda_amqp_test.go
Outdated
Show resolved
Hide resolved
13278ae
to
81ca3e5
Compare
make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccAmqp_basic" |
81ca3e5
to
472df82
Compare
472df82
to
faddccb
Compare
make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccAmqp_basic" |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been approved by: @deer-hang
/approve
/lgtm
What this PR does / why we need it:
commit1: refactor
amqp
resource code stylecommit2:
amqp
resource support new attribute fieldsWhich issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found