Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GaussDB): add gaussdb opengauss tags #6225

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat(GaussDB): add gaussdb opengauss tags #6225

merged 1 commit into from
Jan 20, 2025

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
add gaussdb opengauss tags
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  add gaussdb opengauss tags

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/gaussdb/ TESTARGS='-run TestAccDataSourceOpenGaussTags_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/gaussdb/ -v -run TestAccDataSourceOpenGaussTags_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceOpenGaussTags_basic
=== PAUSE TestAccDataSourceOpenGaussTags_basic
=== CONT  TestAccDataSourceOpenGaussTags_basic
--- PASS: TestAccDataSourceOpenGaussTags_basic (1865.71s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/gaussdb   1865.758s

make testacc TEST=./huaweicloud/services/acceptance/gaussdb/ TESTARGS='-run TestAccDataSourceOpenGaussPredefinedTags_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/gaussdb/ -v -run TestAccDataSourceOpenGaussPredefinedTags_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceOpenGaussPredefinedTags_basic
=== PAUSE TestAccDataSourceOpenGaussPredefinedTags_basic
=== CONT  TestAccDataSourceOpenGaussPredefinedTags_basic
--- PASS: TestAccDataSourceOpenGaussPredefinedTags_basic (13.38s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/gaussdb   13.424s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @houpeng80

@houpeng80 houpeng80 force-pushed the add_gaussdb_opengauss_tags branch from e0df7d0 to 5758056 Compare January 20, 2025 06:39
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 20, 2025
@github-ci-robot github-ci-robot merged commit 963992b into huaweicloud:master Jan 20, 2025
13 checks passed
@houpeng80 houpeng80 deleted the add_gaussdb_opengauss_tags branch January 20, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@houpeng80 @github-ci-robot @Jason-Zhang9309