Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpc): add new resource subnet private IP #6210

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Jason-Zhang9309
Copy link
Collaborator

@Jason-Zhang9309 Jason-Zhang9309 commented Jan 16, 2025

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/vpc' TESTARGS='-run TestAccSubnetPrivateIP_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/vpc -v -run TestAccSubnetPrivateIP_basic -timeout 360m -parallel 4
=== RUN   TestAccSubnetPrivateIP_basic
=== PAUSE TestAccSubnetPrivateIP_basic
=== CONT  TestAccSubnetPrivateIP_basic
--- PASS: TestAccSubnetPrivateIP_basic (89.15s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/vpc       89.206s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Jason-Zhang9309

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 16, 2025
@github-ci-robot github-ci-robot merged commit b620605 into huaweicloud:master Jan 16, 2025
17 checks passed
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-vpc branch January 16, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants