Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cae): add new resource to manage certificate #6207

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:
Add new resource (huaweicloud_cae_certificate) to manage certificate.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new resource.
2. add corresponding document and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o cae -f TestAccCertificate_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/cae" -v -coverprofile="./huaweicloud/services/acceptance/cae/cae_coverage.cov" -coverpkg="./huaweicloud/services/cae" -run TestAccCertificate_basic -timeout 360m -parallel 10
=== RUN   TestAccCertificate_basic
=== PAUSE TestAccCertificate_basic
=== CONT  TestAccCertificate_basic
--- PASS: TestAccCertificate_basic (48.05s)
PASS
coverage: 10.4% of statements in ./huaweicloud/services/cae
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cae       48.127s coverage: 10.4% of statements in ./huaweicloud/services/cae
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

      ab. Related resources (parent resources) not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

      bb. Related resources (parent resources) not found
      image

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 2c86918 into huaweicloud:master Jan 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants