Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CodeArts/Deploy): support to deploy app and get deployment records #6181

Conversation

saf3dfsa
Copy link
Contributor

What this PR does / why we need it:
support to deploy app and get deployment records
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

support to deploy app and get deployment records

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/codeartsdeploy" TESTARGS="-run TestAccDataSourceCodeartsDeployApplicationDeploymentRecords_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/codeartsdeploy -v -run TestAccDataSourceCodeartsDeployApplicationDeploymentRecords_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCodeartsDeployApplicationDeploymentRecords_basic
=== PAUSE TestAccDataSourceCodeartsDeployApplicationDeploymentRecords_basic
=== CONT  TestAccDataSourceCodeartsDeployApplicationDeploymentRecords_basic
--- PASS: TestAccDataSourceCodeartsDeployApplicationDeploymentRecords_basic (43.88s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    43.949s

make testacc TEST="./huaweicloud/services/acceptance/codeartsdeploy" TESTARGS="-run TestAccDeployApplicationDeploy"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/codeartsdeploy -v -run TestAccDeployApplicationDeploy -timeout 360m -parallel 4
=== RUN   TestAccDeployApplicationDeploy_basic
=== PAUSE TestAccDeployApplicationDeploy_basic
=== RUN   TestAccDeployApplicationDeploy_withParams
=== PAUSE TestAccDeployApplicationDeploy_withParams
=== CONT  TestAccDeployApplicationDeploy_basic
=== CONT  TestAccDeployApplicationDeploy_withParams
--- PASS: TestAccDeployApplicationDeploy_withParams (19.29s)
--- PASS: TestAccDeployApplicationDeploy_basic (94.31s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    94.355s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@saf3dfsa saf3dfsa force-pushed the feat(CodeArts/Deploy)_support_to_deploy_app_and_get_deployment_records branch 2 times, most recently from 167bd68 to be171d6 Compare January 13, 2025 07:25
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 20, 2025

## Import

The application deployment record can be imported using `task_id`, and `id`, separated a slash, e.g.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The application deployment record can be imported using `task_id`, and `id`, separated a slash, e.g.
The application deployment record can be imported using `task_id`, and `id`, separated by a slash, e.g.

@saf3dfsa saf3dfsa force-pushed the feat(CodeArts/Deploy)_support_to_deploy_app_and_get_deployment_records branch from be171d6 to d339247 Compare January 20, 2025 08:52
@github-ci-robot github-ci-robot removed the LGTM /lgtm label Jan 20, 2025
@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit 2ce9154 into huaweicloud:master Jan 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants