Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dsc): modify the code style and document description #5853

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Nov 13, 2024

What this PR does / why we need it:

modify the code style and document description.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/dsc' TESTARGS='-run TestAccAssetObs_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dsc -v -run TestAccAssetObs_basic -timeout 360m -parallel 4
=== RUN   TestAccAssetObs_basic
=== PAUSE TestAccAssetObs_basic
=== CONT  TestAccAssetObs_basic
--- PASS: TestAccAssetObs_basic (20.50s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dsc       20.539s
make testacc TEST='./huaweicloud/services/acceptance/dsc' TESTARGS='-run TestAccDscInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dsc -v -run TestAccDscInstance_basic -timeout 360m -parallel 4
=== RUN   TestAccDscInstance_basic
=== PAUSE TestAccDscInstance_basic
=== CONT  TestAccDscInstance_basic
--- PASS: TestAccDscInstance_basic (70.74s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dsc       70.824s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang force-pushed the chore-dsc branch 2 times, most recently from 4334f9f to 70df9fa Compare November 14, 2024 02:37
@github-actions github-actions bot added size/L and removed size/M labels Nov 14, 2024
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 14, 2024
@github-ci-robot github-ci-robot merged commit c297a47 into huaweicloud:master Nov 14, 2024
22 checks passed
@deer-hang deer-hang deleted the chore-dsc branch November 14, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants