Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iotda/data_flow_control_policy): support data flow control policy resource #5852

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Nov 13, 2024

What this PR does / why we need it:

Support data flow control policy resource

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


Support data flow control policy resource

PR Checklist

  • Tests added/passed.
$ export HW_IOTDA_ACCESS_ADDRESS=xxxxxxxx

$ make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccDataFlowControlPolicy_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccDataFlowControlPolicy_ -timeout 360m -parallel 4
=== RUN   TestAccDataFlowControlPolicy_basic
--- PASS: TestAccDataFlowControlPolicy_basic (17.41s)
=== RUN   TestAccDataFlowControlPolicy_channelScope
--- PASS: TestAccDataFlowControlPolicy_channelScope (15.15s)
=== RUN   TestAccDataFlowControlPolicy_ruleScope
--- PASS: TestAccDataFlowControlPolicy_ruleScope (17.47s)
=== RUN   TestAccDataFlowControlPolicy_actionScope
--- PASS: TestAccDataFlowControlPolicy_actionScope (18.23s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda     68.346s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@jinyangyang222 jinyangyang222 force-pushed the feat-iotda/support-data_flow_control_policy-resource branch from eb9bc46 to 8f527f3 Compare November 13, 2024 08:49
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 14, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit e3b5f7b into huaweicloud:master Nov 14, 2024
20 checks passed
@jinyangyang222 jinyangyang222 deleted the feat-iotda/support-data_flow_control_policy-resource branch January 15, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants