Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DDM): add ddm instance groups data source #5842

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
add ddm instance groups data source
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  add ddm instance groups data source

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/ddm/ TESTARGS='-run TestAccDatasourceDdmInstanceGroups_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ddm/ -v -run TestAccDatasourceDdmInstanceGroups_basic -timeout 360m -parallel 4
=== RUN   TestAccDatasourceDdmInstanceGroups_basic
=== PAUSE TestAccDatasourceDdmInstanceGroups_basic
=== CONT  TestAccDatasourceDdmInstanceGroups_basic
--- PASS: TestAccDatasourceDdmInstanceGroups_basic (484.78s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ddm       484.818s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@houpeng80 houpeng80 force-pushed the add_ddm_instance_groups_data_source branch from a95f766 to c87b317 Compare November 13, 2024 01:38
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 13, 2024
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 3000c3f into huaweicloud:master Nov 13, 2024
14 checks passed
@houpeng80 houpeng80 deleted the add_ddm_instance_groups_data_source branch November 13, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants