Support headless startup, x11vnc, noVNC and process control #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @ChisBread ! Thanks for your improvement; it's a lot of work for the system. Before we can continue to review it, could you please file an issue and explain in detail how the whole PR system works? Because without some details, I can not understand the details of each file, and I can not have full confidence to merge it. Also, it would be great if you could invite 1-2 developers who are familiar with this system to give this PR an approvement to make sure everything is good to go! Appreciate it, and have a great day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features only take effect when VNC_SERVER=1