Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember cli 1.13.7 #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

BryanCrotaz
Copy link

Handle ember-cli deprecations:

  1. new getter-setter style
  2. escape styles correctly

@BryanCrotaz
Copy link
Author

Tests need to be re-written to not use views any more

@huafu
Copy link
Owner

huafu commented Aug 25, 2015

@BryanCrotaz thanks a lot but I think with the latest HTMLBars you can simply do stuff like that (correct me if I'm wrong):

<div style="width: {{myWidth}}px; color: {{myColor}}; [...]"></div>

...which makes my addon useless then ;-)

@BryanCrotaz
Copy link
Author

I found that cleaning up your tests to not use Views was really hard so I created a new plugin (and credited you in the readme) - ember-cli-csp-style

@BryanCrotaz
Copy link
Author

The reason we need an addon is to not break CSP rules

@huafu
Copy link
Owner

huafu commented Aug 25, 2015

Oh ok. Anyway I was also thinking about the units and other features such as when the value is null, etc..

Any chance to get the tests passing first?

@BryanCrotaz
Copy link
Author

it needed a complete rewrite to work with ember 2.0, and I figured it was faster to start from a clean ember 2.0 addon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants