Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request for b1-peek-website #289

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

MatthisE
Copy link
Contributor

No description provided.

@gefei
Copy link
Contributor

gefei commented Jan 25, 2024

Please resize your photos. I am sure the photos don't need to have a file size like 1,9 MB

@gefei
Copy link
Contributor

gefei commented Jan 29, 2024

Could you please resize your photos. I will not merge Photos as large as 1,9 MB

@MatthisE
Copy link
Contributor Author

Alright, I resized the images. Is the gif size ok as is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set "draft" to true. Otherwise your page would not be published on the official site

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean false? Because it was already true and we just saw in the readme.md that "draft" should be set to false. So we set it to false now.

@gefei gefei merged commit 6741262 into htw-imi-showtime:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants