Skip to content

Commit

Permalink
updated release process to not release new packages immediately
Browse files Browse the repository at this point in the history
Signed-off-by: Patrik Oldsberg <[email protected]>
  • Loading branch information
Rugvip committed Nov 20, 2021
1 parent 2b00e00 commit ab31a2c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ We use [changesets](https://github.com/atlassian/changesets) to help us prepare

Any time a patch, minor, or major change aligning to [Semantic Versioning](https://semver.org) is made to any published package in `packages/` or `plugins/`, a changeset should be used. It helps to align your change to the [Backstage stability index](https://backstage.io/docs/overview/stability-index) for the package you are changing, for example, when to provide additional clarity on deprecation or impacting changes which will then be included into CHANGELOGs.

In general, changesets are not needed for the documentation, build utilities, contributed samples in `contrib/`, or the [example `packages/app`](packages/app).
In general, changesets are only needed for changes to packages within `packages/` or `plugins/` directories, and only for the packages that are not marked as `private`. Changesets are also not needed for changes that do not affect the published version of each package, for example changes to tests or in-line source code comments.

Changesets **are** needed for new packages, as that is what triggers the package to be part of the next release.

### How to create a changeset

Expand Down
4 changes: 3 additions & 1 deletion scripts/check-if-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ async function main() {

const newVersions = packageVersions.filter(
({ oldVersion, newVersion }) =>
oldVersion !== newVersion && newVersion !== '<none>',
oldVersion !== newVersion &&
oldVersion !== '<none>' &&
newVersion !== '<none>',
);

if (newVersions.length === 0) {
Expand Down

0 comments on commit ab31a2c

Please sign in to comment.