Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run unusedCompileDependenciesTest on the JVM #128

Closed
wants to merge 1 commit into from

Conversation

rossabaker
Copy link
Member

Should help with http4s/http4s#5926.

@armanbilge
Copy link
Member

I'm not sure this will help us. The CI workflow is global to the whole build, not per-project.

What could help is if we added a conditional to this step that only runs if it is a JVM job. But this gets fiddly if we try and account for pure JVM (like the jdk client) or pure JS projects (like dom).

@armanbilge
Copy link
Member

armanbilge commented Jan 22, 2022

I know it doesn't help us right now, but what we should could do is absorb the explicit deps plugin into sbt-typelevel and apply this fix:

@armanbilge
Copy link
Member

armanbilge commented Jan 22, 2022

I have a fix incoming. Edit:

@rossabaker
Copy link
Member Author

Oh, I thought this would run only on the JVM, but I did bake in an assumption everything was using cross project, which is probably not right.

@rossabaker
Copy link
Member Author

#129 is better.

@rossabaker rossabaker closed this Jan 22, 2022
@armanbilge armanbilge deleted the unused-compile-dependences-jvm-only branch March 2, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants