Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tcp nodelay option #806

Closed
wants to merge 5 commits into from
Closed

add tcp nodelay option #806

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e85e7b6
add tcp nodelay option
fiag Mar 1, 2021
93ea7c3
enable tcp_nodelay by default
fiag Mar 2, 2021
480f5ba
Update: move tcp_nodelay option to tcp_listener
fiag Apr 9, 2021
c734118
Merge https://github.com/http-rs/tide into tcp-nodelay
fiag Apr 9, 2021
c6a885e
remove example
fiag Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/listener/tcp_listener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ pub struct TcpListener<State> {
listener: Option<net::TcpListener>,
server: Option<Server<State>>,
info: Option<ListenInfo>,
tcp_nodelay: bool,
}

impl<State> TcpListener<State> {
Expand All @@ -31,6 +32,7 @@ impl<State> TcpListener<State> {
listener: None,
server: None,
info: None,
tcp_nodelay: true,
}
}

Expand All @@ -40,12 +42,25 @@ impl<State> TcpListener<State> {
listener: Some(tcp_listener.into()),
server: None,
info: None,
tcp_nodelay: true,
}
}

/// Gets the value of the TCP_NODELAY option for tcp connections.
pub fn tcp_nodelay(&self) -> bool {
self.tcp_nodelay
}

/// Set the TCP_NODELAY option for tcp connections.
pub fn set_tcp_nodelay(&mut self, tcp_nodelay: bool) -> &mut Self {
self.tcp_nodelay = tcp_nodelay;
self
}
}

fn handle_tcp<State: Clone + Send + Sync + 'static>(app: Server<State>, stream: TcpStream) {
fn handle_tcp<State: Clone + Send + Sync + 'static>(app: Server<State>, stream: TcpStream, tcp_nodelay: bool) {
task::spawn(async move {
stream.set_nodelay(tcp_nodelay).ok();
let local_addr = stream.local_addr().ok();
let peer_addr = stream.peer_addr().ok();

Expand Down Expand Up @@ -111,7 +126,7 @@ where
}

Ok(stream) => {
handle_tcp(server.clone(), stream);
handle_tcp(server.clone(), stream, self.tcp_nodelay);
}
};
}
Expand Down