Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce "single value" model for monochrome graph #928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce "single value" model for monochrome graph #928

wants to merge 1 commit into from

Commits on Jul 16, 2023

  1. Introduce "summary value" for monochrome graph 

    The text labels for CPU, memory and swap go to the trouble of figuring
out a subset of the values to sum, for a single-value summary display.

But the monochrome graph simply summed all `curItems` values. This is
less sophisticated than the label behaviour.

Add a `Meter::summaryValue` member that can be used to output a meter's
custom summary value, and make the graph display use it instead of its
own "all-bars" sum where available.

Implement this in `MemoryMeter`, `SwapMeter` and `CPUMeter`.

This has the effect of making a monochrome memory graph not show cached
memory, so will not be permanently at the top when the cache is heavily
used, and the CPU graph will obey the `account_guest_in_cpu_meter`
setting. In both cases, the graph becomes consistent with the text label
of the bar.
    @kjbracey2
    kjbracey2 committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    152718b View commit details
    Browse the repository at this point in the history