Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beautify the + / - options for numeric fields as shown in the status bar #1613

Closed
wants to merge 1 commit into from
Closed

Beautify the + / - options for numeric fields as shown in the status bar #1613

wants to merge 1 commit into from

Conversation

fasterit
Copy link
Member

Use Unicode full-width characters where available

@fasterit fasterit force-pushed the beautify-inc-dec-statusbar branch from bfb8ba1 to 438734c Compare February 21, 2025 12:36
@fasterit fasterit added this to the 3.4.0 milestone Feb 21, 2025
@BenBE BenBE removed this from the 3.4.0 milestone Feb 21, 2025
@BenBE BenBE added the enhancement Extension or improvement to existing feature label Feb 21, 2025
@BenBE
Copy link
Member

BenBE commented Feb 21, 2025

Tests with the following consoles yielded negative feedback:

  1. QTerminal on Lubuntu 24.10 (default theme) gives a noticeable shift between the two states of the status bar. The symbols are rendered correctly though.

  2. Linux text console (default font used) renders the symbols as U+FFFD and has the noticeable shift in the status bar. With the symbols not properly showing, this is a usability regression.

I'd suggest to stick with the ASCII-only version where proper display of information is key (and actually carries essential information).

@fasterit
Copy link
Member Author

As stated on IRC: 😭
or :-( for those living on ASCII still

fasterit pushed a commit to fasterit/htop that referenced this pull request Feb 21, 2025
Make Dec and Inc consistent on F7 and F8 as per the main panel
6a4a08a 
* minus and plus keys still work
* this prevents the ugly left flush "- " and "+ " key labels
* Unicode "－" and "＋" are still to hard in 2025, see PR htop-dev#1613 😭

Closes htop-dev#1613
@fasterit fasterit mentioned this pull request Feb 21, 2025
Merged
fasterit pushed a commit to fasterit/htop that referenced this pull request Feb 21, 2025
Make Dec and Inc consistent on F7 and F8 as per the main panel
32a967a 
* minus and plus keys still work
* this prevents the ugly left flush "- " and "+ " key labels
* Unicode "－" and "＋" are still too hard in 2025, see PR htop-dev#1613 😭

Closes htop-dev#1613
@BenBE BenBE closed this in #1615 Feb 21, 2025
@BenBE BenBE closed this in faa4832 Feb 21, 2025
@Explorer09
Copy link
Contributor

@fasterit Just for your info: Many fonts designed with Latin scripts only will not contain glyphs for the fullwidth Latin block. The fullwidth characters you are using are for the CJK scripts. That is, you generally need a CJK font installed before the fullwidth glyphs can be displayed properly.

I like the alternative of using F7 and F8 instead of "-" and "+" for display in #1615, however.

@fasterit fasterit deleted the beautify-inc-dec-statusbar branch February 25, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Extension or improvement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fasterit @BenBE @Explorer09