darwin: fix process state visualization in DarwinProcessTable #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBE
added
enhancement
BenBE
requested changes
Feb 19, 2025
aestriplex
force-pushed
the
darwin-process-status
branch
from
d74abc3 to
1eb2aee
Compare
BenBE
approved these changes
Feb 20, 2025
BenBE
pushed a commit
that referenced
this pull request
Feb 21, 2025
Closes #1611 Co-authored-by: aestriplex <[email protected]> Co-authored-by: Explorer09 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with the process state column on macOS. All the processes but htop itself are marked as ProcessState.UNKNOWN ('?'). This behavior was referenced in this old issue: #622.
DarwinProcess_scanThreadscontains the code related to the mach subsystem, that retrieves the information thread by thread. For some of them (as process state information) this is not necessary. We have this information right in thekinfo_procstructure, allocated inDarwinProcessTable.c. This allows us to avoid dealing with threads unless strictly necessary, such as in the case of process state information.We have an analogous issue with the running time, that is not updated during the execution of the program, but I'll open a separated pr for that.