Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Settings.c cleanup #1531

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Minor Settings.c cleanup #1531

merged 6 commits into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. Refactor column delete into a shared Settings_deleteColumns

    Rather than open-coding it twice, use a shared routine for
    deleting columns from the Settings structure.  In order to
    improve code readability refactor the screen array deletion
    similarly and call both routines from Settings_delete.
    natoscott committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5735e79 View commit details
    Browse the repository at this point in the history
  2. Pass Machine pointer to Settings_new instead of internal detail

    Be more flexible and consistent with the way other structures
    are initialised by passing a pointer to struct Machine into the
    Settings constructor.  This would allow other alternative setup
    of default Meters in the future, e.g. for some nvtop-alike tool
    sharing code with htop (hypothetically) showing GPUs instead of
    CPUs by default.  Mainly it just makes the code easier to read.
    natoscott committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    89ec44b View commit details
    Browse the repository at this point in the history
  3. Remove long-dead code

    BenBE committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e1cc9ea View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    fbd1425 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d9f4bf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    efd05e0 View commit details
    Browse the repository at this point in the history