-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strace issue #1529
Fix strace issue #1529
Conversation
TraceScreen.h
Outdated
@@ -23,6 +23,7 @@ typedef struct TraceScreen_ { | |||
FILE* strace; | |||
bool contLine; | |||
bool follow; | |||
bool status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name "status" is unreadable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, reading through the issue description AND looking at the code, I think status
is not very intuitive. I think a better name would be strace_running
or strace_alive
.
Didn't get what you are actually trying to solve. What is the error or problem you are facing? And how to reproduce it? |
Reproduce method:
|
Please give this a read-through: https://marker.io/blog/how-to-write-bug-report Those information should normally appear in the top-most post, where they are easy to find. You can edit your initial post to update these information. And while I have a hinch what you are talking about, I'll ask you to be precise in your bug report/pull request first to avoid misunderstandings about the scope of what you are trying to achieve. |
TraceScreen.h
Outdated
@@ -23,6 +23,7 @@ typedef struct TraceScreen_ { | |||
FILE* strace; | |||
bool contLine; | |||
bool follow; | |||
bool status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, reading through the issue description AND looking at the code, I think status
is not very intuitive. I think a better name would be strace_running
or strace_alive
.
3441de4
to
65d9446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the coding style of htop and indent with three spaces. (Yeah, not many projects use three-space indents, but htop is an exception here.)
… CPU to be fully loaded.
Fixed the issue that the CPU is fully loaded due to the process exiting tracked by strace.
Reproduce the process: