Resolve a problem in F2/Setup update interval adjustments #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBE
added
bug 🐛
The halfdelay(3X) curses function ultimately drives the update interval that htop samples values and refreshes at. This is a bit complicated by interrupts generated from other places (key or mouse events), however if halfdelay is not explicitly called at some point soon after changing the interval it does not get correctly updated during that session. Since the delay setting is persisted, on restart htop actually does honour the change from the previous invocation, confusing the situation even further. With this commit the update is reflected immediately in the UI as well now. Fixes: htop-dev#1510
No reason to have two pointers when one will do the trick, and the code becomes a little less obfuscated as a result.
natoscott
force-pushed
the
fix-delay-updates
branch
from
51370d6
to
4c4a5fb
Compare
BenBE
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The halfdelay(3X) curses function ultimately drives the update interval that htop samples values and refreshes at. This is a bit complicated by interrupts generated from other places (key or mouse events), however if halfdelay is not explicitly called at some point soon after changing the interval it does not get correctly updated during that session.
Since the delay setting is persisted, on restart htop actually does honour the change from the previous invocation, confusing the situation even further.
With this commit the update is reflected immediately in the UI as well now.
Fixes: #1510