-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a meta-check for ncurses detection #1506
Conversation
Something seems off with the Ubuntu build. Any ideas? |
I get the same on a local build with `--enable-static`` (on Debian bookworm) after your change:
previously it compiles fine to a static executable and the configure output snippet is:
|
Does it build with |
Yes, it does.
|
The problem in my opinion is that it doesn't make sense to let user specify how to check ncurses. The user should only specify whether ncurses exists, and optionally how to link to it. Now, when it comes to automatic detection of
|
@Explorer09 Please see the linked patch from OpenEmbedded for context. |
@BenBE I did read the linked patch, and thus I get the conclusion we are doing the wrong way. The |
Ideally the method with which you can detect ncurses should not matter. The special case with OpenEmbedded is that you are building a system (from scratch) with minimal tooling available in the build environment, thus it's totally reasonable for them to assume pkg-config to be available (minimal dev tooling), but not ncurses-config (which may need emulation to run). After all OpenEmbedded is usually used for cross-building, thus minimizing reliance on tooling used in build systems is absolutely justified. What I'm more confused about though is that pkg-config seems to fail when finding |
This was inspired by a patch for OpenEmbedded: https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-support/htop/files/0001-Use-pkg-config.patch?id=110667ac3798b5b64552cb4b8dc706aad8fbcdfe Using this patch, detection can be switched as appropriate.
ea6b278
to
479f736
Compare
I implemented the idea in #1512. Please take a look and make some comments. |
This was inspired by a patch for OpenEmbedded:
https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-support/htop/files/0001-Use-pkg-config.patch?id=110667ac3798b5b64552cb4b8dc706aad8fbcdfe
Using this patch, detection can be switched as appropriate.