Don't use Angular 5 packages for an Angular 4 based project #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Resolves the problem of the compiler being for Angular 5, which is incompatible with Angular 4 based projects when attempting to run the Ionic project with the --prod flag.
What is the current behavior?
At the moment on an Angular 4 based project you cannot run Ionic with the --prod flag because of the dependency inclusion of Angular 5 packages (angular/compiler & angular/compiler-cli), which is incompatible because of a version mismatch (3 to 4).
Issue Number: #161
What is the new behavior?
This reverts the package dependency of angular/compiler and angular/compiler-cli to be 4.4.6 so that it is compatible with the rest of the packages in package.json (Angular 4.4.6)
Does this PR introduce a breaking change?
This will introduce a problem for Angular 5 based packages, but my suggestion below would fix that.
Other information
I would suggest splitting this off into an Angular 4 branch, and having current master be updated for Angular 5, rather than having mixed 4/5 dependencies.